Skip to content

Improve display and editing logic for default vs. custom roles #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Improve display and editing logic for default vs. custom roles #118

merged 1 commit into from
Apr 9, 2025

Conversation

chriscarrollsmith
Copy link
Contributor

@chriscarrollsmith chriscarrollsmith commented Apr 9, 2025 •
edited
Loading

  • Always display roles table on the organization detail page, not just when there are custom roles
  • Disallow editing default roles, via both client side and server side logic
  • Verify these new behaviors in the test suite

@chriscarrollsmith
- Disallow editing default roles
866995c 
- Always display roles table, not just when there are custom roles
- Verify these new behaviors in the test suite
@chriscarrollsmith chriscarrollsmith linked an issue Apr 9, 2025 that may be closed by this pull request
Adjust behavior of roles table on organizations page #113
Closed
@chriscarrollsmith chriscarrollsmith merged commit a46446f into main Apr 9, 2025
2 checks passed
@chriscarrollsmith chriscarrollsmith deleted the 113-adjust-behavior-of-roles-table-on-organizations-page branch April 9, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust behavior of roles table on organizations page
1 participant
@chriscarrollsmith